New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3: modifications of modernize tool, some minor manual fixes to keep python2 compatibility #135

Merged
merged 1 commit into from Jun 16, 2017

Conversation

Projects
None yet
2 participants
@rapgro

rapgro commented Feb 3, 2016

No description provided.

@rapgro

This comment has been minimized.

Show comment
Hide comment
@rapgro

rapgro Feb 3, 2016

Owner

For backwards compatibility to python2:

try:
    import urlparse
except ImportError:
    # The urlparse module is renamed to urllib.parse in Python 3. 
    import urllib.parse as urlparse
Owner

rapgro commented on rabbitvcs/util/helper.py in 7df3cd2 Feb 3, 2016

For backwards compatibility to python2:

try:
    import urlparse
except ImportError:
    # The urlparse module is renamed to urllib.parse in Python 3. 
    import urllib.parse as urlparse
@rapgro

This comment has been minimized.

Show comment
Hide comment
@rapgro

rapgro Feb 3, 2016

Owner

To keep with urlparse.urlparse is better for backwards compatibility to python2, see above.

Owner

rapgro commented on rabbitvcs/util/helper.py in 7df3cd2 Feb 3, 2016

To keep with urlparse.urlparse is better for backwards compatibility to python2, see above.

@rapgro

This comment has been minimized.

Show comment
Hide comment
@rapgro

rapgro Feb 3, 2016

Owner

To keep with urlparse.urlparse is better for backwards compatibility to python2, see above.

Owner

rapgro commented on rabbitvcs/util/helper.py in 7df3cd2 Feb 3, 2016

To keep with urlparse.urlparse is better for backwards compatibility to python2, see above.

@rapgro

This comment has been minimized.

Show comment
Hide comment
@rapgro

rapgro Feb 3, 2016

Owner

To keep with urlparse.urlparse is better for backwards compatibility to python2, see above.

Owner

rapgro commented on rabbitvcs/util/helper.py in 7df3cd2 Feb 3, 2016

To keep with urlparse.urlparse is better for backwards compatibility to python2, see above.

@rapgro

This comment has been minimized.

Show comment
Hide comment
@rapgro

rapgro Feb 3, 2016

Owner

To keep with urlparse.urlunparse is better for backwards compatibility to python2, see above.

Owner

rapgro commented on rabbitvcs/util/helper.py in 7df3cd2 Feb 3, 2016

To keep with urlparse.urlunparse is better for backwards compatibility to python2, see above.

@rapgro

This comment has been minimized.

Show comment
Hide comment
@rapgro

rapgro Feb 3, 2016

Owner

Please mind my notes to rabbitvcs/util/helper.py

Owner

rapgro commented on 7df3cd2 Feb 3, 2016

Please mind my notes to rabbitvcs/util/helper.py

@rapgro

This comment has been minimized.

Show comment
Hide comment
@rapgro

rapgro Feb 3, 2016

Owner

filter() gives a boolean value, so conversion in a list is obviously wrong. That's a bug in modernize tool.

Owner

rapgro commented on rabbitvcs/util/helper.py in 7df3cd2 Feb 3, 2016

filter() gives a boolean value, so conversion in a list is obviously wrong. That's a bug in modernize tool.

@adamplumb

This comment has been minimized.

Show comment
Hide comment
@adamplumb

adamplumb Jun 16, 2017

This PR is a bit intimidating but I tested it manually and it seems fine. If it moves things closer to modern times and python3 then that's a good thing. Thanks for putting the time in and sorry this took so long!

adamplumb commented Jun 16, 2017

This PR is a bit intimidating but I tested it manually and it seems fine. If it moves things closer to modern times and python3 then that's a good thing. Thanks for putting the time in and sorry this took so long!

@adamplumb adamplumb merged commit 10c92a2 into rabbitvcs:master Jun 16, 2017

@rapgro

This comment has been minimized.

Show comment
Hide comment
@rapgro

rapgro Jun 16, 2017

Better late than never. Thanks for the review and approval of my PR. I'm glad this project is still alive.

rapgro commented Jun 16, 2017

Better late than never. Thanks for the review and approval of my PR. I'm glad this project is still alive.

@adamplumb

This comment has been minimized.

Show comment
Hide comment
@adamplumb

adamplumb Jun 16, 2017

It's definitely on life support, but I'm hoping to put some time into it to at least make it usable for people and at least make it less buggy.

adamplumb commented Jun 16, 2017

It's definitely on life support, but I'm hoping to put some time into it to at least make it usable for people and at least make it less buggy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment