New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to show process arguments #23

Closed
TheAmigo opened this Issue Jan 25, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@TheAmigo

TheAmigo commented Jan 25, 2016

When there are multiple instances of a process running, it would be much more helpful to if nethogs could show the arguments to all processes.

@raboof

This comment has been minimized.

Show comment
Hide comment
@raboof

raboof Jan 25, 2016

Owner

Agreed! Perhaps we should add a -c flag like top

Owner

raboof commented Jan 25, 2016

Agreed! Perhaps we should add a -c flag like top

@raboof

This comment has been minimized.

Show comment
Hide comment
@raboof

raboof Nov 16, 2016

Owner

Hmm, we actually already show the arguments, right? For example I see ..sr/lib/chromium/chromium --show-component-extension-options --ignore-gpu-blacklist --disable-background-n.

Related to #103 .

Owner

raboof commented Nov 16, 2016

Hmm, we actually already show the arguments, right? For example I see ..sr/lib/chromium/chromium --show-component-extension-options --ignore-gpu-blacklist --disable-background-n.

Related to #103 .

@TheAmigo

This comment has been minimized.

Show comment
Hide comment
@TheAmigo

TheAmigo Nov 16, 2016

On RHEL 7.1 running the nethogs 0.8.5 (built from source) I don't see arguments for any process. Lots of "ssh", "/usr/bin/perl", and other commands, but no arguments for any of the. Tried both "sudo nethogs" and running nethogs from a root shell... still no arguments.
screenshot_2016-11-16_11-47-40

TheAmigo commented Nov 16, 2016

On RHEL 7.1 running the nethogs 0.8.5 (built from source) I don't see arguments for any process. Lots of "ssh", "/usr/bin/perl", and other commands, but no arguments for any of the. Tried both "sudo nethogs" and running nethogs from a root shell... still no arguments.
screenshot_2016-11-16_11-47-40

@raboof

This comment has been minimized.

Show comment
Hide comment
@raboof

raboof Nov 19, 2016

Owner

Ah, it seems chromium does something 'special' there: if I look at /proc/<pid>/cmdline, usually for commands like perl the command is separated from the parameters with \0 characters, but for chrome they're spaces. Odd.

Owner

raboof commented Nov 19, 2016

Ah, it seems chromium does something 'special' there: if I look at /proc/<pid>/cmdline, usually for commands like perl the command is separated from the parameters with \0 characters, but for chrome they're spaces. Odd.

@TheAmigo

This comment has been minimized.

Show comment
Hide comment
@TheAmigo

TheAmigo Nov 19, 2016

I don't have Chrome installed on this machine right now so I can't check... it's possibly an artifact of a wrapper script Chrome uses that ends up joining all its arguments with spaces between them. Null bytes are the standard delimiter so that individual arguments can have space in them without being confused with being separate args.

TheAmigo commented Nov 19, 2016

I don't have Chrome installed on this machine right now so I can't check... it's possibly an artifact of a wrapper script Chrome uses that ends up joining all its arguments with spaces between them. Null bytes are the standard delimiter so that individual arguments can have space in them without being confused with being separate args.

@anomen-s

This comment has been minimized.

Show comment
Hide comment
@anomen-s

anomen-s Nov 20, 2016

Contributor

I confirm, Chrome rewrites cmdline,
https://cs.chromium.org/chromium/src/content/common/set_process_title.cc

As for this issue, I almost finished implemetation, anomen-s/nethogs@d74711e

Contributor

anomen-s commented Nov 20, 2016

I confirm, Chrome rewrites cmdline,
https://cs.chromium.org/chromium/src/content/common/set_process_title.cc

As for this issue, I almost finished implemetation, anomen-s/nethogs@d74711e

anomen-s added a commit to anomen-s/nethogs that referenced this issue Nov 24, 2016

@raboof raboof closed this in 5e2c357 Jan 1, 2017

raboof added a commit that referenced this issue Jan 1, 2017

Merge pull request #108 from anomen-s/issue-23-r
Add -l option to show full command line (fixes #23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment