Correctly count CRLF newlines when counting line offsets.

[akovaski]

This allows completion coordinates to find the correct position in the file when using Windows style newlines (CRLF). I added two simple tests which are slight tweaks of the coords_to_point_works test in core.rs.

Notably for me, this allows RLS autocomplete to function correctly when working on files with Windows style newlines.

See issue 976 in the rust-lang/rls repo. I believe this behavior was merged to the racer github repo on Jun 24, 2018 with commit 42046fc.

Example image of the autocomplete problem in VSCode on Windows. This is a file with CRLF newlines. Notice that the cursor is on line 7, but the auto-completion is for the code that exists on line 5.

Now the autocomplete will autocomplete line 5 at the end of line 5, where the user will want it to. 🎉

[Xanewok]

Nice find! This actually fixes Windows CI failure for RLS, which was mismatched auto-completion based on lines https://travis-ci.org/Xanewok/rls/jobs/465194944 (errors because of debug Error: StringError("actually ok") but it's actually fixed now) 🎉

[kngwyu]

Great, thanks 👍
@Xanewok
Should I publish new version for rls?

[Xanewok]

@kngwyu I think that’d be great, yes. Windows users get their autocompletion back so I think that alone meets the point release bar 👍

[kngwyu]

Published v2.1.15 now

[kngwyu]

I yanked 2.1.15 because of a really silly miss 4c2d363
Please use 2.1.16 😓

[Xanewok]

Thanks for the release!