New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_nested_query() ignores empty arrays #122

Closed
sheldon-b opened this Issue Feb 10, 2015 · 7 comments

Comments

Projects
None yet
7 participants
@sheldon-b

sheldon-b commented Feb 10, 2015

Is it intentional that build_nested_query ignores empty arrays in its output? I have code working on the assumption that empty arrays would be passed through. It was a bit of a pain tracking down where it was being lost.

https://github.com/brynary/rack-test/blob/master/lib/rack/test/utils.rb#L10

@imtayadeway

This comment has been minimized.

imtayadeway commented Apr 28, 2015

i also spent some time tracking down this issue. i'd be interested to know if it's a feature/bug, and where this goes.

@akabraham

This comment has been minimized.

akabraham commented Apr 29, 2015

+1. I'm also running into this exact same issue. This Stack Overflow post also cites the same thing

@stefan-kolb

This comment has been minimized.

stefan-kolb commented Jul 23, 2015

+1

2 similar comments
@yuszuv

This comment has been minimized.

yuszuv commented Oct 5, 2015

+1

@shllg

This comment has been minimized.

shllg commented Oct 5, 2015

+1

@scepticulous

This comment has been minimized.

Contributor

scepticulous commented Feb 29, 2016

+1

Having the same issue, but the PR creates a string containing [] in my case. Can anyone confirm or tell me how they worked around this.
This issue is now almost a year old.

@stale

This comment has been minimized.

stale bot commented Apr 20, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 20, 2018

@stale stale bot closed this Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment