Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

"Bad URI" error on unicode URIs #56

Closed
bhollis opened this Issue Apr 1, 2012 · 2 comments

Comments

Projects
None yet
3 participants

bhollis commented Apr 1, 2012

in rack/test.rb:171, URI.parse is used to create a URI instance. Unfortunately, the uri library cannot handle URIs with unicode characters in them: http://bugs.ruby-lang.org/issues/1787

It'd be nice if rack-test avoided URI or was able to take advantage of something like https://github.com/sporkmonger/addressable which handles unicode URIs correctly. Even allowing URI-like objects to be passed into Rack::Test methods without being parsed (so we could use Addressable ourselves) would be great.

@bhollis bhollis referenced this issue in middleman/middleman-blog Apr 1, 2012

Closed

Support UTF-8 Characters in File Names #19

Contributor

scepticulous commented May 3, 2017

@perlun @junaruga I think we can close this since the original linked bug in ruby is fixed as wel.

Member

junaruga commented May 4, 2017

@scepticulous yes I think so. You can close it without getting an agreement from me.

@bhollis Thanks for the report.
http://bugs.ruby-lang.org/issues/1787 for Ruby 1.9 was fixed. It looks working from Ruby 2.0. For that reason, I would close this ticket. However if you will still see the issue on Ruby >= 2.2, please reopen this ticket and tell us.

@junaruga junaruga closed this May 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment