New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopping generating gemspec file. #181

Merged
merged 1 commit into from May 30, 2017

Conversation

Projects
None yet
2 participants
@junaruga
Member

junaruga commented May 29, 2017

This fixes #169

Summary

Detail

  • rack-test.gemspec
    • Replacing from double quote " to single quote ' is to pass rubocop latest version 0.49.0 test. There is one violation error for the rubocop test for here document. But can not avoid it.
    • s.files: I only included files under lib and some document files.
      This way removing test files is maybe new popular. For example you can see it on rails/rails, rspec/rspec-*, the merit is we can reduce the file size of gem.
    • s.required_rubygems_version: Removed. Removing it looks no harmful, referring other packages' gemspec files. The item looks auto-generated by RubyGems. See the result of gem specification on Travis CI.
    • s.extra_rdoc_files: Removed. It looks no harmful.
    • s.rubyforge_project: Removed. Outdated? We don't use Rubyforge.
    • s.rubygems_version: Removed. We don't want to maintain the version.
      I did not see this item at rais/rails, rspec-core.
      http://guides.rubygems.org/specification-reference/#rubygems_version

      Do not set this, it is set automatically when the gem is packaged.

    • s.test_files: Removed. Seeing http://guides.rubygems.org/specification-reference, it look outdated tag. Also I did not see it on rails.
    • s.add_dependency or s.add_runtime_dependency ?
      Both are same meaning items. But maybe add_runtime_dependency is newer than add_dependency. Seeing rails/rails add_dependency is used. So, I used it for the compativility of older Rubies.

I also removed/updated those items referring http://guides.rubygems.org/specification-reference/ , rails/rails and rspec/rspec-core. So, if you have questions, please let me know.

  • .travis.yml

    • The release test is too much? :)
  • Thorfile

    • My concern is $ bundle exec thor :install itself is not useful. Because gem install --local pkg/rack-test-*.gem is run in the Bundler world.
$ bundle show rack-test
/home/jaruga/git/rack-test

$ bundle exec thor :build
gem build rack-test.gemspec
  Successfully built RubyGem
  Name: rack-test
  Version: 0.6.3
  File: rack-test-0.6.3.gem

$ bundle exec thor :install

$ bundle show rack-test
/home/jaruga/git/rack-test

How to test

$ bundle exec thor :build

$ gem install --user-install pkg/rack-test-0.6.3.gem

$ gem list | grep rack-test
rack-test (0.6.3)

irb(main):003:0> require 'rack/test'
=> true

$ gem specification pkg/rack-test-0.6.3.gem --ruby

$ cd pkg/

$ gem unpack rack-test-0.6.3.gem 
Unpacked gem: '/home/jaruga/git/rack-test/pkg/rack-test-0.6.3'

$ ls rack-test-0.6.3
History.md  lib/  MIT-LICENSE.txt  README.md

@junaruga junaruga changed the title from Stopped generating gemspec file. to Stopping generating gemspec file. May 29, 2017

@perlun

perlun approved these changes May 30, 2017

Looks good to me. Thanks @junaruga!

Stop generating gemspec file.
* Because the generating is confusing us including contributors.
* The reason of new file lib/rack/test/version.rb is because of preventing
  an error when "rack/test" is loaded recursively in gemspec file.
* Add release way to README again because that is useful
  for people who do release.

@junaruga junaruga merged commit 8d02976 into rack-test:master May 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@junaruga

This comment has been minimized.

Member

junaruga commented May 30, 2017

@perlun thanks for checking my code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment