Join GitHub today
Rubocop fixes #196
This makes the
A lot of this is just:
But, the good part about this is that we can now run Rubocop on each Travis build, to ensure that new code follows the Rubocop rules as defined in .rubocop.yml
In my opinion, if possible, we should fix each code climate complains for each PR.
Thanks to you both!
Well, we don't really have a decision other than using the defaults as provided by Rubocop. I think most of these make sense, but there are cases where I typically deviate (you saw it mentioned in the PR in the .rubocop.yml change).
Yes, that'd be the idea. If people have spare time and want to work on cleaning these issues up, they are very welcome to do so.
With this change in place, the Rubocop rules will run:
That's of course a bit silly, but we can live with it for now. (It seems the codeclimate settings use a different version of Rubocop - if someone knows how to fix that, please do. OTOH, we could disable Rubocop on codeclimate since we already run it on Travis anyway.)