New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rack::JSONP::VALID_JS_CHARS missing brackets and quotes #123

Closed
naliwajek opened this Issue Feb 22, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@naliwajek

naliwajek commented Feb 22, 2016

Hello,

I'm using callback from Pusher in my app: Pusher.auth_callbacks['1'] and it is currently invalid:

Rack::JSONP::VALID_CALLBACK =~ "Pusher.auth_callbacks['1']"
=> nil

Is there a reason why [, ], ' and " aren't allowed?

Overriding this isn't much of a pain but it takes some time to debug it. I'll be happy to submit a PR if possible.

Cheers.

@mpalmer

This comment has been minimized.

Contributor

mpalmer commented Jul 18, 2017

A PR, with tests, would be appreciated. I have no direct experience with JSONP, so I really have no idea what the answer is.

@mpalmer mpalmer closed this Jul 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment