Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fixed a conflict between rack-contrib and ruby-prof #18

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
5 participants

mirakui commented Nov 5, 2010

"RubyProf" descriptions in lib/rack/contrib/profiler.rb are conflict with latest version of ruby-prof.
Replaced them to "::RubyProf" and it works well.
https://github.com/rdp/ruby-prof/issues/issue/44

matth commented on ca5d1b8 Nov 4, 2010

Hi, this fixes a fairly annoying bug with the new versions of ruby-prof - they have added their own middleware:

https://github.com/rdp/ruby-prof/blob/master/lib/ruby-prof/rack.rb

Can you do a pull request to rack/rack-contrib and see if we can get this in the main branch? I'd rather use this middleware.

matth replied Nov 4, 2010

Put a ticket in with the ruby-prof guys too, just to make them aware of the conflict ...

https://github.com/rdp/ruby-prof/issues/issue/44

Owner

mirakui replied Nov 5, 2010

OK I sent pull-request to them.
Thank you for your notification :)

+1

I prefer the rack-contrib version (as it doesn't write to a file but instead sends out to the webserver). Changing my Gemfile to use mirakui's fork solved my problem. Thanks everybody!

@mpalmer mpalmer added the mpalmer-ok label Oct 31, 2014

@mpalmer mpalmer referenced this pull request Oct 31, 2014

Closed

Profiler cleanup #24

Contributor

jjb commented Nov 2, 2014

The link to the above ticket is broken, here is the new one: ruby-prof/ruby-prof#44

Contributor

jjb commented Nov 2, 2014

Looks like the ruby-prof project fixed this on their end in 2010. I'm closing this PR.

@jjb jjb closed this Nov 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment