Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix bug with domain caching for common cookies in production #21

Merged
merged 1 commit into from

2 participants

@brainopia

The change is very simple - removal of domain memoization in common_cookies.rb

@brainopia

@lifo can you help me? I've contributed this middleware and now I can't get a fix to it :)

@rkh rkh merged commit 6f33726 into rack:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 4 deletions.
  1. +2 −4 lib/rack/contrib/common_cookies.rb
View
6 lib/rack/contrib/common_cookies.rb
@@ -19,10 +19,8 @@ def call(env)
private
def domain
- @domain ||= begin
- @host =~ DOMAIN_REGEXP
- ".#{$1}.#{$2}"
- end
+ @host =~ DOMAIN_REGEXP
+ ".#{$1}.#{$2}"
end
def share_cookie(headers)
Something went wrong with that request. Please try again.