Profiler cleanup #24

Closed
wants to merge 2 commits into
from

Projects

None yet

5 participants

@MasterLambaster

Some minor cleanup for profiler. Also added content type for missing html printer.

@masterkain

This fixes Rack::Profiler for me 100%, merge please?

@masterkain

News about this?

@rkh
Official Rack repositories member

Rebase please.

@mpalmer

I prefer the approach in #18 to this one. The addition of a content type for ::RubyProf::CallStackPrinter => 'text/html' in 95a895f is unique to this PR, though, so I'll leave it open for now until I or someone else splits that out separately.

@mpalmer mpalmer added the needs-work label Oct 31, 2014
@jjb
jjb commented Nov 2, 2014

we don't need the rubyprof namespace fix anymore

i don't have comprehension of what 95a895f is achieving. @MasterLambaster if you would still like that change, submit again in another PR, with explanation for why it's needed.

closing this PR.

@jjb jjb closed this Nov 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment