Profiler cleanup #24

wants to merge 2 commits into


None yet

5 participants


Some minor cleanup for profiler. Also added content type for missing html printer.


This fixes Rack::Profiler for me 100%, merge please?


News about this?

Official Rack repositories member

Rebase please.


I prefer the approach in #18 to this one. The addition of a content type for ::RubyProf::CallStackPrinter => 'text/html' in 95a895f is unique to this PR, though, so I'll leave it open for now until I or someone else splits that out separately.

@mpalmer mpalmer added the needs-work label Oct 31, 2014
jjb commented Nov 2, 2014

we don't need the rubyprof namespace fix anymore

i don't have comprehension of what 95a895f is achieving. @MasterLambaster if you would still like that change, submit again in another PR, with explanation for why it's needed.

closing this PR.

@jjb jjb closed this Nov 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment