Fix to allow :duration as a float (eg :duration => 0.2 ~ 1 Week) #50

Closed
wants to merge 1 commit into
from

4 participants

@brutuscat

While I have it working I wanted to have more control over the expire time. Kind of weird but works ;)

@brutuscat

Sorry: 0.019 ~ 1 Week

@rkh
Official Rack repositories member

Could you add a test?

@mpalmer

Definitely needs a test, and some documentation.

@mpalmer mpalmer added the needs-work label Oct 31, 2014
@jjb
jjb commented Nov 2, 2014

@rkh requested a test in 2012 and @brutuscat is MIA, so I'd vote for closing this.

@mpalmer

We can add the tests, if we think the feature is worth having . I think the feature is worth having, at any rate.

@jjb
jjb commented Nov 2, 2014

k

@brutuscat

@mpalmer @jjb feature IS in master 46d85e4#diff-0 by @pvdb with test and all.

@jjb
jjb commented Nov 3, 2014

hah, so it is! i guess github shows the merge for this one as being clean because it's a NOOP.

thanks for getting back to us @brutuscat!

closing this PR

@jjb jjb closed this Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment