Is useful. Solves for Issue #49
added 'times' to be called in the query string
This sets @times for all requests, though. How about setting it just for the current request?
it should set @times for just the request here https://github.com/rack/rack-contrib/pull/52/files#L0R30 without overwriting the more global times setting
@brycem a single middleware instance is used for all requests, so setting an instance variable here means the @times setting will apply to every subsequent request.
so there's really no way to solve Issue #49?
Well that's a leap! ;)
You could pass times as a local variable instead of setting the instance variable.
@brycem will merge if you rebase onto master.
yikes, it's been 9 months?! I'll add times as a local variable and then rebase
I really like the concept of this PR. I've got a few concerns, however:
this PR has a lot of problems and @brycemcd hasn't responded to feedback. also the included test is weak, uses instance_variable_get. i vote for closing this.
I forgot this was even open. I haven't looked at it in ~ 2 years. If it's really something that would be useful (to more than just @mpalmer ;) ) I can clean it up and re-submit.
I'll do the needful on this PR, and get it ready for release.
While you're add it, might be nice to have a line of documentation for this feature in the comments.
Also: @mperham -- any news thoughts on this since your request (#49) in 2012?
@jjb hence the needs-docs tag. (grin)
Ah, excellent :)
@mpalmer looks like interest in this has really picked up. I'm happy to jump back in and resubmit (using your overview on Oct. 31, 2104) and do the doc update if you'd like. Let me know either way.
The only reason I didn't resubmit before was because I didn't think there was any interest
@brycemcd, yes rack-contrib was moribund for a while, but a group of us are working to bring it back to life. If you could put together some docs and cleanup, that would be very helpful, as it would leave me free to put the polish on other PRs. We're doing monthly feature releases (first-of-the-month or so), so whenever you're able to get it sorted, it'll be released shortly thereafter.
@mpalmer happy to help out. I have another PR I'm working on at the moment, but I just set aside some time next week to get this taken care of.
I've created #111 as a cleaned-up version of this PR. Closing this one.