Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Remove deprecated 'rake/rdoctask', replace with new invocation. #61

Merged
merged 2 commits into from

5 participants

@mipearson

Required for rake 10.

@jeremy
Owner

Perhaps this deserves adding a dev dependency on rake to the gemspec?

@raggi
Owner

You mean rdoc and rake...

@mpalmer
Owner

Yes, oh yes, oh ghods yes.

@mpalmer mpalmer added the mpalmer-ok label
@jjb
Collaborator
jjb commented

I'm not familiar with this issue but looks legit.

Should it be in a major release because there is a dependency change?

@jjb
Collaborator
jjb commented

or at this point can it be considered a bug...

@mpalmer
Owner

A dependency change doesn't require a major release change, IMO. Nothing in the user's code has to change.

@jjb
Collaborator
jjb commented

k

@jjb
Collaborator
jjb commented

happy to merge then

let's wait 48 hours to see if any of the other folks chime in

@mpalmer mpalmer merged commit 4ce89d0 into rack:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 2 deletions.
  1. +2 −2 Rakefile
  2. +2 −0  rack-contrib.gemspec
View
4 Rakefile
@@ -1,5 +1,5 @@
# Rakefile for Rack::Contrib. -*-ruby-*-
-require 'rake/rdoctask'
+require 'rdoc/task'
require 'rake/testtask'
desc "Run all the tests"
@@ -26,7 +26,7 @@ task :fulltest do
end
desc "Generate RDoc documentation"
-Rake::RDocTask.new(:rdoc) do |rdoc|
+RDoc::Task.new(:rdoc) do |rdoc|
rdoc.options << '--line-numbers' << '--inline-source' <<
'--main' << 'README' <<
'--title' << 'Rack Contrib Documentation' <<
View
2  rack-contrib.gemspec
@@ -101,6 +101,8 @@ Gem::Specification.new do |s|
s.add_development_dependency 'test-spec', '>= 0.9.0'
s.add_development_dependency 'tmail', '>= 1.2'
s.add_development_dependency 'json', '>= 1.1'
+ s.add_development_dependency 'rake', '>= 10.0.3'
+ s.add_development_dependency 'rdoc', '>= 3.12'
s.has_rdoc = true
s.homepage = "http://github.com/rack/rack-contrib/"
Something went wrong with that request. Please try again.