Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

EnforceValidEncoding middleware. #64

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

mipearson commented Jan 1, 2013

Since migrating our application to Ruby 1.9 from Ruby 1.8 most of our logged exceptions have been due to spam bots sending bad UTF8 in query strings and paths.

This middleware rejects any path or query string that does not decode correctly.

The test in this PR depends on my other pull request that converts rack-contrib's specs to use bacon instead of specrb.

@mpalmer mpalmer added the mpalmer-ok label Oct 31, 2014

Contributor

jjb commented Nov 2, 2014

depends on #63

new feature, so i'm marking it as for the next feature release

@jjb jjb added this to the 1.3 milestone Nov 2, 2014

@mpalmer mpalmer removed the mpalmer-ok label Jun 22, 2015

@mpalmer mpalmer removed this from the 1.3 milestone Jun 22, 2015

@mpalmer mpalmer added the needs-docs label Jun 22, 2015

Contributor

mpalmer commented Jun 22, 2015

No docs, and the test suite fails for minimum versions, though; that'll need to be fixed up before it can land. I'm a fan of this concept, though; I'll rummage around on it at some stage and get it ready to land.

@mpalmer mpalmer self-assigned this Jun 22, 2015

@mpalmer mpalmer added this to the 1.3 milestone Jun 26, 2015

Contributor

mpalmer commented Jun 26, 2015

Merged.

Contributor

jjb commented Jun 26, 2015

@mpalmer merged? or just tagged as 3.1? (maybe I am behind the times on github milestone features)

Contributor

mpalmer commented Jun 26, 2015

All these are merged, they were just rebased before merge, so Github doesn't totally understand what's going on.

Contributor

jjb commented Jun 26, 2015

ahh.

i find that when i rebase onto master and force push, github figures it out just fine. sometimes comments are lost, but the PR remains healthy. did something else happen in these cases?

Contributor

mpalmer commented Jun 26, 2015

No, I don't think so.

Contributor

jjb commented Jun 27, 2015

¯\_(ツ)_/¯

@mpalmer mpalmer closed this Jul 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment