Fix CVE-2014-4671 #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Bump. This is a security fix. What's the hold up? |
manveru
added a commit
that referenced
this pull request
Sep 21, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVE-2014-4671 describes a reflection attack using JSONP callbacks to cause a trusted domain to return a malicious SWF that can make requests to the trusted domain with the victims credentials. The attack relies on having control over the first byte of the response, and therefore can be mitigated by prepending valid Javascript to the response.
A more detailed write up of the attack and mitigations can be found at http://miki.it/blog/2014/7/8/abusing-jsonp-with-rosetta-flash/