Browse files

Changing incorrect documentation

The original comment on set_session said to return true or false
depending on whether the session was saved or not. In reality, this
method MUST return the session id in order for #commit_session to set
the cookie data properly.
  • Loading branch information...
1 parent c56fbf4 commit 9dfb64da02328b99144bb4f712071baf441822c4 @aocole aocole committed Jan 25, 2013
Showing with 2 additions and 2 deletions.
  1. +2 −2 lib/rack/session/abstract/id.rb
@@ -359,8 +359,8 @@ def get_session(env, sid)
# All thread safety and session storage proceedures should occur here.
- # Should return true or false dependant on whether or not the session
- # was saved or not.
+ # Must return the session id if the session was saved successfully, or
+ # false if the session could not be saved.
def set_session(env, sid, session, options)
raise '#set_session not implemented.'

0 comments on commit 9dfb64d

Please sign in to comment.