Skip to content
Commits on Jul 6, 2008
  1. @qerub @chneukirchen

    Added support for Accept-Encoding (via Request#accept_encoding and Ut…

    …ils.select_best_encoding)
    qerub committed with chneukirchen Jul 1, 2008
Commits on Apr 10, 2008
  1. @chneukirchen

    handle EOFError exception in Request#params

    darcs-hash:20080410202632-0c10b-e89c6619864024b884e6f85cda0a4e13f6f176fa.gz
    chneukirchen committed Apr 10, 2008
Commits on Mar 27, 2008
  1. Bug fix for Tempfile POST bodies under Ruby 1.8

    The Tempfile class in Ruby 1.8 doesn't implement the == method correctly.
    This causes Rack::Requests to re-parse the input (when the input is a
    Tempfile) each time the POST method is called, this in turn raises an
    EOFError because the input has already been read.
    
    One example of when this happens is when handling large POST requests
    (e.g. file uploads) under Mongrel.
    
    This issue only effects Ruby 1.8 (tested against 1.8.6).  Ruby 1.9 does
    not suffer from this issue (presumably due to changes in the Delegate
    implementation.)
    
    darcs-hash:20080327110953-ea3b8-44b6f22da80c9dae70dcd61adc43111547371daf.gz
    Adam Harper committed Mar 27, 2008
Commits on Mar 15, 2008
  1. @chneukirchen

    Fix that Request assumes form-data even when Content-Type says otherwise

    Fixes cases where accessing Request#params causes the body to be read and
    processed as form-data improperly. For example, consider the following
    request:
    
        PUT /foo/bar?baz=bizzle HTTP/1.1
        Content-Type: text/plain
    
        This is not form-data.
    
    When Rack::Request gets ahold of the corresponding environment, and the
    application attempts to access the "baz" query string param, the body is read
    and interpreted as form-data. If the body is an IOish object, this causes the
    offset to be forwarded to the end of file.
    
    The patch prevents the Request#POST method from going into the body unless the
    media type is application/x-www-form-urlencoded, multipart/form-data, or not
    specified.
    
    While here, added a few unrelated helper methods to Request that I've found
    particularly useful in Rack apps: #content_length, #head?, and #content_charset.
    
    Tests and doc included for all changes.
    
    darcs-hash:20080315135144-8bfab-f12391851f188ab1467b7e3d825f1e196058210d.gz
    chneukirchen committed Mar 15, 2008
Commits on Feb 24, 2008
  1. @chneukirchen

    Fix cookie parsing

    darcs-hash:20080224184600-4fc50-a0c322c967df89d53bc73aa5c581df08a6f99339.gz
    chneukirchen committed Feb 24, 2008
Commits on Jan 21, 2008
  1. Conform to RFC 2109 regarding multiple values for same cookie

    darcs-hash:20080121022706-569a4-169599904497663951a065ad134920401bda2f20.gz
    Aman Gupta committed Jan 21, 2008
Commits on May 16, 2007
  1. @chneukirchen

    Fix trailing whitespace. Sigh.

    darcs-hash:20070516145358-4fc50-4b716d93f0cc24d1e988443228312c6bcdfc1e7b.gz
    chneukirchen committed May 16, 2007
Commits on May 15, 2007
  1. @manveru

    add some features to Request and the corresponding tests for them

    darcs-hash:20070515234231-cbc08-3272b1798cabaaf261e9c69ed191bcf5e84b315f.gz
    manveru committed May 15, 2007
Commits on Mar 30, 2007
  1. @chneukirchen

    Add Request#fullpath

    darcs-hash:20070330131207-4fc50-87a99ab267b2d73ae6b59623b5d98a6a325f233b.gz
    chneukirchen committed Mar 30, 2007
Commits on Mar 1, 2007
  1. @chneukirchen

    Add RDocs

    darcs-hash:20070301185301-4fc50-159ee23dc4ab0c209dcbf8d7e014a308d72434d7.gz
    chneukirchen committed Mar 1, 2007
Commits on Feb 28, 2007
  1. @chneukirchen

    Remove the port number of HTTP_HOST and SERVER_NAME

    darcs-hash:20070228134524-4fc50-5d243c4c75a9fece6ffaa9421d631f9b7498b6e0.gz
    chneukirchen committed Feb 28, 2007
  2. @chneukirchen

    Make Rack::Request read multipart form data

    darcs-hash:20070228125648-4fc50-ce858f8df7bdc362bd689cbc84c5a92805e03ebe.gz
    chneukirchen committed Feb 28, 2007
Commits on Feb 21, 2007
  1. @qerub

    Add getter method for the query string (and use it internally)

    darcs-hash:20070221222514-ae511-43b5126c066e22bfdfcab100d4953a00dc0c294b.gz
    qerub committed Feb 21, 2007
  2. @chneukirchen

    Add Request#url

    darcs-hash:20070221170342-4fc50-415bd697c2f0dcb8c261b79a211ec6ab6034bb62.gz
    chneukirchen committed Feb 21, 2007
Commits on Feb 19, 2007
  1. @chneukirchen

    Return empty hash on lack of cookies

    darcs-hash:20070219112219-4fc50-6a7d41c9531790f9645ab477852172492412b021.gz
    chneukirchen committed Feb 19, 2007
  2. @chneukirchen

    Cache the parsed things in Rack::Request

    darcs-hash:20070219102328-4fc50-7ab0cded7d668f04d3427e7fc55158c61e28b003.gz
    chneukirchen committed Feb 19, 2007
Commits on Feb 18, 2007
  1. @chneukirchen

    Rename Request#method to #request_method to not confuse stdlibs

    darcs-hash:20070218232335-4fc50-728da935ad40a6054a7e46a96fd794984bc6f311.gz
    chneukirchen committed Feb 18, 2007
  2. @chneukirchen

    More convenience for Rack::Request

    darcs-hash:20070218105007-4fc50-17859a47ae55c4c6704dbaefa5a7209ee1e0e32d.gz
    chneukirchen committed Feb 18, 2007
Commits on Feb 17, 2007
  1. @chneukirchen

    Don't define path_info twice

    darcs-hash:20070217125718-4fc50-0fbca2edfded651fc9bcb38576a2420c0f4b203d.gz
    chneukirchen committed Feb 17, 2007
Commits on Feb 16, 2007
  1. @chneukirchen

    Add Rack::Response and Rack::Utils

    darcs-hash:20070216163453-4fc50-0d0fcd15fe7bcc67d3a317ddba810caee004a49e.gz
    chneukirchen committed Feb 16, 2007
  2. @chneukirchen

    Add Rack::Request

    darcs-hash:20070216153205-4fc50-397855182b9d3d9dded0edb36ff5dbfdbfe91f82.gz
    chneukirchen committed Feb 16, 2007
Something went wrong with that request. Please try again.