Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Regression with Rack::File.new(nil) #1471
I updated rack to 2.1.0 on my Rails 184.108.40.206 app, and it broke with the active storage disk controller.
It has been changed here in version 2.1.0 of Rack.
On the git repository of Rails, it seems this code is not called anymore and that should be fixed in a subsequent version of Rails.
But browsing version 5.2 of Rails showed the same issue here, which makes me think the responsibility would come from Rack to fix it.
I think we could just fix it by expanding the root path only when the root path is not nil, but I am not familiar at all with this codebase and it might be more complicated than that.
FYI there was a Stackoverflow question here starting it: https://stackoverflow.com/questions/59691691/rails-typeerror-no-implicit-conversion-of-nil-into-string-when-loading-image/59693773#59693773