Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression with Rack::File.new(nil) #1471

Closed
gverger opened this issue Jan 11, 2020 · 3 comments
Closed

Regression with Rack::File.new(nil) #1471

gverger opened this issue Jan 11, 2020 · 3 comments

Comments

@gverger
Copy link

@gverger gverger commented Jan 11, 2020

Hello,

I updated rack to 2.1.0 on my Rails 6.0.2.1 app, and it broke with the active storage disk controller.
It seems that it comes from this line in rails, where Rack::File.new(nil) is called.

It has been changed here in version 2.1.0 of Rack.

On the git repository of Rails, it seems this code is not called anymore and that should be fixed in a subsequent version of Rails.

But browsing version 5.2 of Rails showed the same issue here, which makes me think the responsibility would come from Rack to fix it.

I think we could just fix it by expanding the root path only when the root path is not nil, but I am not familiar at all with this codebase and it might be more complicated than that.

@gverger

This comment has been minimized.

@tagliala

This comment has been minimized.

Copy link
Contributor

@tagliala tagliala commented Jan 11, 2020

Hi, I've stumbled into this

Found a duplicate of this issue: #1464

This has already been fixed on rack master via 1b82d84

@ioquatix

This comment has been minimized.

Copy link
Member

@ioquatix ioquatix commented Jan 11, 2020

I think the rails use case is fragile. We didn't expect root to be nil. However, we've reverted the change and added specs for this use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.