Rack 1.4.3 tests should not assume that hardcoded /tmp is writeable #492

Closed
graaff opened this Issue Jan 13, 2013 · 3 comments

Projects

None yet

2 participants

@graaff
graaff commented Jan 13, 2013

When running tests as part of our install mechanism on Gentoo Linux the tests for Rack 1.1.4 fail because in our sandboxed environment /tmp isn't writeable at that point. It would be better to use TMPDIR instead, and fall back to /tmp when that isn't set.

@raggi
Member
raggi commented Jan 13, 2013

Header of report says 1.4.3, content says 1.1.4. I presume you really mean "all versions".

Unfortunately, this isn't easy to fix for all tests, as we would have to dynamically generate the lighttpd config. I can do it, but it won't be part of these releases.

Is this a blocking problem for you?

@raggi
Member
raggi commented Jan 13, 2013

If I can just fix this on 1.5+ that would be much preferred (easier)

@graaff
graaff commented Jan 15, 2013

Sorry for the confusion with the version numbers. No, I meant 1.4.3 only. I think we skip some tests on Gentoo, so this is only blocking for us on test/spec_sendfile.rb. We currently apply this patch. http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/dev-ruby/rack/files/rack-1.4.3-tmpdir.patch?view=markup

@raggi raggi added a commit that closed this issue Jan 21, 2013
@raggi raggi Use Dir.tmpdir instead of hardcoded /tmp
Closes #492
73d3b26
@raggi raggi closed this in 73d3b26 Jan 21, 2013
@raggi raggi added a commit that referenced this issue Jan 21, 2013
@raggi raggi Use Dir.tmpdir instead of hardcoded /tmp
Closes #492
d466718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment