Webrick handler has typo that prevents correct setting of rack.url_scheme #532

Closed
timaro opened this Issue Mar 23, 2013 · 0 comments

Projects

None yet

1 participant

@timaro

The webrick handler has a typo in line 73 that prevents the correct setting of rack.url_scheme unless ENV['HTTPS'] is defined. The check should be for env['HTTPS'] instead. It's that way in the mongrel handler, and webrick does set env['HTTPS'] on SSL requests.

The bug is in all versions of rack that I've looked at, including the latest releases.

@rkh rkh pushed a commit that closed this issue Apr 12, 2013
@oscardelben oscardelben Don't rely on ENV. Fixes #532 0b8909a
@rkh rkh closed this in 0b8909a Apr 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment