Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP


Invalid params key encoding raises uncaught ArgumentError #610

nanaya1 opened this Issue · 3 comments

4 participants


This regexp check:

name =~ %r(\A[\[\]]*([^\[\]]+)\]*)

will raise uncaught ArgumentError when name has invalid encoding. Is it the intended behavior?

Fork with relevant test.

rkh commented

We only have it it specified for, but the raw string is expected to be binary encoded.


unescape function called here decodes the string to utf-8 (by default) though. And by extension, there's good chance the regexp matcher will raise exception on anything but Encoding::BINARY.

@raggi raggi added this to the Rack 1.6 milestone

Fixed by #713

@tenderlove tenderlove closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.