Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Style/FrozenStringLiteralComment in rubocop #1256

Merged
merged 12 commits into from Apr 17, 2018

Conversation

yhirano55
Copy link
Contributor

@yhirano55 yhirano55 commented Apr 16, 2018

Summary

  • Enabled Style/FrozenStringLiteralComment in rubocop, and executed auto-correct.
  • Removed duplicated magic comments in Rack::RewindableInput
  • Enabled Layout/LeadingCommentSpace in rubocop, and executed

.rubocop.yml Outdated
EnforcedStyle: always
Exclude:
- 'example/**/*'
- 'test/builder/**/*'
Copy link
Collaborator

@rafaelfranca rafaelfranca Apr 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this rule disabled on tests?

Copy link
Contributor Author

@yhirano55 yhirano55 Apr 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafaelfranca Thanks for the comment. You're right. It doesn't need to set Exclude. So I've removed it and added frozen_string_literal comments to all files.

@yhirano55 yhirano55 force-pushed the enable_frozen_string_literal_style branch from e16cfcb to 7ef0b4f Compare Apr 17, 2018
@jeremy jeremy merged commit b3d01da into rack:master Apr 17, 2018
4 of 5 checks passed
@yhirano55 yhirano55 deleted the enable_frozen_string_literal_style branch Apr 17, 2018
@ahorek ahorek mentioned this pull request Jul 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants