Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upEnable Style/FrozenStringLiteralComment in rubocop #1256
Merged
Conversation
.rubocop.yml
Outdated
| EnforcedStyle: always | ||
| Exclude: | ||
| - 'example/**/*' | ||
| - 'test/builder/**/*' |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yhirano55
Apr 17, 2018
Author
Contributor
@rafaelfranca Thanks for the comment. You're right. It doesn't need to set Exclude. So I've removed it and added frozen_string_literal comments to all files.
yhirano55
force-pushed the
yhirano55:enable_frozen_string_literal_style
branch
from
e16cfcb
to
7ef0b4f
jeremy
merged commit b3d01da
into
rack:master
4 of 5 checks passed
4 of 5 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
yhirano55 commentedApr 16, 2018
Summary
Style/FrozenStringLiteralCommentin rubocop, and executed auto-correct.Rack::RewindableInputLayout/LeadingCommentSpacein rubocop, and executed