Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Style/FrozenStringLiteralComment in rubocop #1256

Merged
merged 12 commits into from Apr 17, 2018

Conversation

@yhirano55
Copy link
Contributor

yhirano55 commented Apr 16, 2018

Summary

  • Enabled Style/FrozenStringLiteralComment in rubocop, and executed auto-correct.
  • Removed duplicated magic comments in Rack::RewindableInput
  • Enabled Layout/LeadingCommentSpace in rubocop, and executed
EnforcedStyle: always
Exclude:
- 'example/**/*'
- 'test/builder/**/*'

This comment has been minimized.

Copy link
@rafaelfranca

rafaelfranca Apr 17, 2018

Collaborator

Why is this rule disabled on tests?

This comment has been minimized.

Copy link
@yhirano55

yhirano55 Apr 17, 2018

Author Contributor

@rafaelfranca Thanks for the comment. You're right. It doesn't need to set Exclude. So I've removed it and added frozen_string_literal comments to all files.

@yhirano55 yhirano55 force-pushed the yhirano55:enable_frozen_string_literal_style branch from e16cfcb to 7ef0b4f Apr 17, 2018
@jeremy jeremy merged commit b3d01da into rack:master Apr 17, 2018
4 of 5 checks passed
4 of 5 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: test-ruby-2.2 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby-2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby-2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby-2.5 Your tests passed on CircleCI!
Details
@yhirano55 yhirano55 deleted the yhirano55:enable_frozen_string_literal_style branch Apr 17, 2018
@ahorek ahorek mentioned this pull request Jul 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.