Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call the correct accepts_html? method for prefer_plaintext #1296

Merged
merged 1 commit into from Sep 13, 2018

Conversation

@tomelm
Copy link
Contributor

tomelm commented Sep 5, 2018

I noticed that prefers_plaintext? is calling a non-existent accepts-html method. This was working in 1.5.x and looks like it changed starting in 1.6.x. We use prefers_plaintext?so we need this to make upgrading possible.

Would it be possible to get this added into a 1.6.x release too? This PR is forked off of master so I'm happy to open another PR with a similar fix that's forked off of 1-6-stable (I wasn't sure the preferred way to do that).

@rafaelfranca rafaelfranca merged commit 72a5d18 into rack:master Sep 13, 2018
5 of 6 checks passed
5 of 6 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
ci/circleci: test-jruby Your tests passed on CircleCI!
Details
ci/circleci: test-ruby-2.2 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby-2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby-2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby-2.5 Your tests passed on CircleCI!
Details
rafaelfranca added a commit that referenced this pull request Sep 13, 2018
Call the correct accepts_html? method for prefer_plaintext
rafaelfranca added a commit that referenced this pull request Sep 13, 2018
Call the correct accepts_html? method for prefer_plaintext
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.