Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Lambda handler #1337
I've never used AWS lambda, so I don't really understand this code. I can read it and see what it does, but no idea how to use this with AWS lambda so I can't really comment on it. Any reason for adding this to Rack rather than making a gem? I'm not against adding it necessarily, just curious if there's a reason to put it in core.
Rack doesn't actually have handlers for Puma or Unicorn, they're defined in the webserver gems themselves. The list of build-in handlers is here.
I'm not opposed to putting handlers in Rack itself, but I think it's better to be put in a gem because
This is why the popular web servers don't ship handlers in Rack. Given there's already a serverless Rack solution, maybe adding an implementation as an example would be better.
What do you think?
Sorry I listed the wrong handlers
Ok, I will move it into a separate gem.