Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Preserve forwarded IP address for trusted proxy chains #1343

Merged
merged 1 commit into from Feb 19, 2019

Conversation

@larsxschneider
Copy link

larsxschneider commented Feb 19, 2019

This is a backport to 2-0-stable of @SamSaffron's fix which was merged to master with #1224

@eileencodes @tenderlove it would be super awesome if you could make a new rack release with this backport 馃槉 .


Sometimes proxies make requests to Rack applications, for example
HAProxy health checks and so on.

Previously the forwarded IP implementation ate up these IP addresses,
making it hard to tell in Rack applications who made the request

Sometimes proxies make requests to Rack applications, for example
HAProxy health checks and so on.

Previously the forwarded IP implementation ate up these IP addresses,
making it hard to tell in Rack applications who made the request
@eileencodes eileencodes merged commit ea57610 into rack:2-0-stable Feb 19, 2019
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@larsxschneider larsxschneider deleted the larsxschneider:ls/forward-fix branch Feb 20, 2019
tigefa4u pushed a commit to tigefa4u/gitlabhq that referenced this pull request Apr 5, 2019
This update has two important fixes:

1. It reverts the monkey patch introduced in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/23385 since
rack/rack#1201 is now part of the release.

2. Preserve forwarded IP address for trusted proxy chains
(rack/rack#1343).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.