Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPEC: Require "status" to be Integer and >= 100 (BREAKING CHANGE) #1662

Merged
merged 1 commit into from May 24, 2020

Conversation

@olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented May 24, 2020

This PR adds a SPEC change: "require Status to be an Integer >100".

The change is: check status.is_a?(Integer) before trying the >=.

  • Tests which tested the previous, lenient #to_i-accepting behavior: dropped

See comment in #1644

@olleolleolle olleolleolle force-pushed the olleolleolle:integer-gt-100-in-spec branch from 1ec7944 to 362d40c May 24, 2020
@ioquatix
Copy link
Member

@ioquatix ioquatix commented May 24, 2020

Great work, can you please add an entry to the changelog as this is a breaking change.

@ioquatix ioquatix added the SPEC label May 24, 2020
@ioquatix ioquatix added this to the v3.0.0 milestone May 24, 2020
  - #1644 refers to the idea "require Status to be an Integer"
  - This implements that change
@olleolleolle olleolleolle force-pushed the olleolleolle:integer-gt-100-in-spec branch from 362d40c to 5063b3d May 24, 2020
@olleolleolle
Copy link
Contributor Author

@olleolleolle olleolleolle commented May 24, 2020

@ioquatix Not many BREAKING CHANGE markers in there, I imitated one I found.

@olleolleolle olleolleolle changed the title SPEC: Require "status" to be Integer and >= 100 SPEC: Require "status" to be Integer and >= 100 (BREAKING CHANGE) May 24, 2020
@ioquatix ioquatix merged commit ba25ade into rack:master May 24, 2020
12 checks passed
12 checks passed
test (ubuntu-latest, 2.4)
Details
test (ubuntu-latest, 2.5)
Details
test (ubuntu-latest, 2.6)
Details
test (ubuntu-latest, 2.7)
Details
test (ubuntu-latest, jruby)
Details
test (ubuntu-latest, truffleruby-head)
Details
test (macos-latest, 2.4)
Details
test (macos-latest, 2.5)
Details
test (macos-latest, 2.6)
Details
test (macos-latest, 2.7)
Details
test (macos-latest, jruby)
Details
test (macos-latest, truffleruby-head)
Details
@ioquatix
Copy link
Member

@ioquatix ioquatix commented May 24, 2020

Thanks for your effort.

@olleolleolle olleolleolle deleted the olleolleolle:integer-gt-100-in-spec branch May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.