Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPEC: Require "status" to be Integer and >= 100 (BREAKING CHANGE) #1662

merged 1 commit into from May 24, 2020


Copy link

@olleolleolle olleolleolle commented May 24, 2020

This PR adds a SPEC change: "require Status to be an Integer >100".

The change is: check status.is_a?(Integer) before trying the >=.

  • Tests which tested the previous, lenient #to_i-accepting behavior: dropped

See comment in #1644

Copy link

Great work, can you please add an entry to the changelog as this is a breaking change.

@ioquatix ioquatix added the SPEC label May 24, 2020
@ioquatix ioquatix added this to the v3.0.0 milestone May 24, 2020
  - rack#1644 refers to the idea "require Status to be an Integer"
  - This implements that change
Copy link
Contributor Author

@ioquatix Not many BREAKING CHANGE markers in there, I imitated one I found.

@olleolleolle olleolleolle changed the title SPEC: Require "status" to be Integer and >= 100 SPEC: Require "status" to be Integer and >= 100 (BREAKING CHANGE) May 24, 2020
@ioquatix ioquatix merged commit ba25ade into rack:master May 24, 2020
Copy link

Thanks for your effort.

@olleolleolle olleolleolle deleted the integer-gt-100-in-spec branch May 24, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants