SPEC: Require "status" to be Integer and >= 100 (BREAKING CHANGE) #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
force-pushed
the
integer-gt-100-in-spec
branch
from
1ec7944
to
362d40c
Compare
|
Great work, can you please add an entry to the changelog as this is a breaking change. |
- rack#1644 refers to the idea "require Status to be an Integer" - This implements that change
olleolleolle
force-pushed
the
integer-gt-100-in-spec
branch
from
362d40c
to
5063b3d
Compare
|
@ioquatix Not many BREAKING CHANGE markers in there, I imitated one I found. |
olleolleolle
changed the title
|
Thanks for your effort. |
This was referenced Mar 8, 2021
Open
Open
This was referenced Mar 15, 2021
This was referenced Mar 17, 2021
auroranockert
added a commit
to auroranockert/rack
that referenced
this pull request
Aug 6, 2022
This documents what you need to do to be compatible with rack#1662.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a SPEC change: "require Status to be an Integer >100".
The change is: check
status.is_a?(Integer)before trying the >=.#to_i-accepting behavior: droppedSee comment in #1644