Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove options from Builder#parse_file & Builder#load_file. #1663

merged 1 commit into from May 24, 2020


Copy link

No description provided.

Copy link
Member Author

There are lots of tests that write app, _ = Builder.parse_file. I've left them. The _ now becomes nil which I think is acceptable for backwards compatibility.

Can you see anything else we need to do?

cc @tenderlove

Copy link

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ioquatix ioquatix merged commit b95cb72 into rack:master May 24, 2020
@ioquatix ioquatix deleted the remove-options branch May 24, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants