Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove options from `Builder#parse_file` & `Builder#load_file`. #1663

Merged
merged 1 commit into from May 24, 2020

Conversation

@ioquatix
Copy link
Member

@ioquatix ioquatix commented May 24, 2020

No description provided.

@ioquatix ioquatix force-pushed the ioquatix:remove-options branch from aa03d61 to 3cb0931 May 24, 2020
@ioquatix ioquatix requested a review from jeremyevans May 24, 2020
@ioquatix
Copy link
Member Author

@ioquatix ioquatix commented May 24, 2020

There are lots of tests that write app, _ = Builder.parse_file. I've left them. The _ now becomes nil which I think is acceptable for backwards compatibility.

Can you see anything else we need to do?

cc @tenderlove

Copy link
Collaborator

@jeremyevans jeremyevans left a comment

Looks good to me.

@ioquatix ioquatix merged commit b95cb72 into rack:master May 24, 2020
16 checks passed
16 checks passed
test (ubuntu-latest, 2.4)
Details
test (ubuntu-latest, 2.5)
Details
test (ubuntu-latest, 2.6)
Details
test (ubuntu-latest, 2.7)
Details
test (ubuntu-latest, jruby)
Details
test (ubuntu-latest, truffleruby-head)
Details
test (macos-latest, 2.4)
Details
test (macos-latest, 2.5)
Details
test (macos-latest, 2.6)
Details
test (macos-latest, 2.7)
Details
test (macos-latest, jruby)
Details
test (macos-latest, truffleruby-head)
Details
external (ubuntu-latest, 2.6)
Details
external (ubuntu-latest, 2.7)
Details
external (macos-latest, 2.6)
Details
external (macos-latest, 2.7)
Details
@ioquatix ioquatix deleted the ioquatix:remove-options branch May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.