Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The stream argument must implement #<<. #1959

merged 3 commits into from Aug 31, 2022


Copy link

This makes it easier to use the stream argument with template systems like ERB, Trenni, etc for real time template streaming/generation.

Copy link

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally thought it would best to only add this restriction on callable bodies (i.e. not for hijack), as that approach would not introduce backwards compatibility issues. However, I guess there is no really issue with also doing so for hijack, and there is an advantage in keeping things consistent between the two (callable bodies operating exactly the same as partial hijack currently).

Copy link
Member Author

I understand. I've deliberately tried to keep rack partial hijack and rack streaming response semantics identical to make it easier for server implementor.

@ioquatix ioquatix merged commit 6aad539 into main Aug 31, 2022
@ioquatix ioquatix deleted the stream-insertion-operator branch August 31, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants