Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing through streaming bodies. #1993

merged 3 commits into from Dec 5, 2022


Copy link

@ioquatix ioquatix commented Dec 5, 2022

An alternative to #1987 which allows passing through streaming bodies without considering status code (e.g. allowing 101 response with streaming body).

Copy link

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with the behavior. See inline comments.

lib/rack/response.rb Outdated Show resolved Hide resolved
lib/rack/response.rb Outdated Show resolved Hide resolved
lib/rack/response.rb Outdated Show resolved Hide resolved
@ioquatix ioquatix merged commit 0e9ea5f into main Dec 5, 2022
25 checks passed
@ioquatix ioquatix deleted the rack-response-ignore-1xx-streaming-body branch December 5, 2022 04:59
ioquatix added a commit that referenced this pull request Dec 5, 2022
tenderlove added a commit that referenced this pull request Jan 17, 2023
* 3-0-sec: (24 commits)
  bump version
  Update changelog
  Fix ReDoS vulnerability in multipart parser
  Fix ReDoS in Rack::Utils.get_byte_ranges
  Forbid control characters in attributes
  Bump patch version.
  `Rack::Request#POST` should consistently raise errors. (#2010)
  Fix Rack::Lint error message for HTTP_CONTENT_TYPE and HTTP_CONTENT_LENGTH (#2007)
  Rack::MethodOverride handle QueryParser::ParamsTooDeepError (#2006)
  Bump patch version.
  Fix Regexp deprecated third argument with Regexp::NOENCODING (#1998)
  Update tests to work on latest Rubies. (#1999)
  Bump patch version.
  Allow passing through streaming bodies. (#1993)
  Remove unnecessary executable bit from test files (#1992)
  Fix Utils.build_nested_query to URL-encode all query string fields (#1989)
  Trim trailing white space throughout the project (#1990)
  Fix some typos (#1991)
  Remove leading dot to fix compatibility with latest cgi gem. (#1988)
  Fix outdated Rack::Builder rdocs and remove Lobster references (#1986)
@ioquatix ioquatix mentioned this pull request Jan 25, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants