Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Cleanup URLMap #280

Merged
merged 1 commit into from Dec 5, 2011

Conversation

Projects
None yet
2 participants
Contributor

evanphx commented Dec 5, 2011

URLMap was a little harder to follow than it need be, so I used my handy
Code Dremel(tm) on it.

I've removed the uses of Hash#merge! since they unnessarily created
extra Hash objects just to update the env.

@evanphx evanphx Cleanup the style and minor perf of URLMap
URLMap was a little harder to follow than it need be, so I used my handy
Code Dremel(tm) on it.

I've removed the uses of Hash#merge! since they unnessarily created
extra Hash objects just to update the env.
6ccb913

@raggi raggi added a commit that referenced this pull request Dec 5, 2011

@raggi raggi Merge pull request #280 from evanphx/master
Cleanup URLMap
afc09df

@raggi raggi merged commit afc09df into rack:master Dec 5, 2011

Owner

raggi commented Dec 5, 2011

Gosh, i still hate this code, anyway, thank you so much!

Contributor

evanphx commented Dec 5, 2011

Yeah, it could still use some work. Perhaps I'll take another pass at it!

Owner

raggi commented Dec 5, 2011

It is not expected, but if you do, that would be awesome! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment