Use Rack::Lint in all tests #290

Closed
wants to merge 1 commit into from

2 participants

@lgierth

ALL the tests

I recently stumbled upon my fix for #235 again and noticed that I hadn't modified the tests to use Rack::Lint and make sure no regressions will be introduced in the future. I also noticed that hardly any of the tests were using Rack::Lint as a means of verifying spec compliance. Middleware MUST conform to the spec and we can't be sure it does if we don't have tests for it.

This is just a first round with a few updated tests included to gather some feedback, I'll update the other tests if people are positive on this.

@lgierth lgierth Wrap test apps in Rack::Lint (first pass)
Update tests for Auth::Basic, Auth::Digest, Builder, Casecase, Handler::CGI,
Chunked, CommonLogger and ConditionalGet.
22284cb
@raggi raggi closed this Dec 21, 2011
@raggi
Official Rack repositories member

Merged, thanks!

@lgierth

Thanks, I'll update the other tests as well.

@raggi
Official Rack repositories member

@lgierth please note the 1.8/1.9 fix I had to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment