Fix for Issue #299 #304

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@ciberch
ciberch commented Jan 4, 2012

Allow old_secret to be optional so we don't break backwards compatibility
Fix for Issue #299

@raggi
Member
raggi commented Jan 7, 2012

Thanks for the patches, but I want to squash this before I merge.

@ciberch
ciberch commented Jan 7, 2012

@raggi cool thanks. Here it is squashed

@raggi raggi added a commit that closed this pull request Jan 7, 2012
@raggi raggi Add missing spec coverage for when secrets do not match (ACHTUNG!)
Fix Rack::Session::Cookie when old_secret or secret are not supplied.
Always encode cookies with one of the two secret options, if provided, preferencing :secret
Based on contribution from ciberch. Closes #304. Closes #299.
08e0eb0
@raggi raggi closed this in 08e0eb0 Jan 7, 2012
@raggi
Member
raggi commented Jan 7, 2012

Apologies, I actually rewrote your patch. Thank you for your contribution.

@ciberch
ciberch commented Jan 7, 2012

Thanks for addressing the issue. Hopefully next time Ill be able to get the
opportunity to update my pull request. I even used the IRC room to check
with manveru.

On Sat, Jan 7, 2012 at 2:53 PM, James Tucker <
reply@reply.github.com

wrote:

Apologies, I actually rewrote your patch. Thank you for your contribution.


Reply to this email directly or view it on GitHub:
#304 (comment)

@lsiden
lsiden commented Jan 8, 2012

Thank you @ciberch and @raggi! James, what branch did you merge this into? I don't see it yet. I'll want to update my Rack gem once it's available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment