Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix request loop on non-stale nonce with time_limit parameter. #406

Merged
merged 1 commit into from Aug 26, 2012

Conversation

Projects
None yet
3 participants
Contributor

dayflower commented Jul 12, 2012

On HTTP Digest auth (MD5), when Rack::Auth::Digest::Nonce.time_limit is set, stale? function of Nonce always returns false. So user-agent's re-challenges never succeed. As a consequence, request-response infinitely loops.

This pull request fails (merged 4f81156 into edc8b92).

raggi added a commit that referenced this pull request Aug 26, 2012

Merge pull request #406 from dayflower/fix-time-limit
Fix request loop on non-stale nonce with time_limit parameter.

@raggi raggi merged commit d749c46 into rack:master Aug 26, 2012

Owner

raggi commented Aug 26, 2012

Thanks!

@dayflower dayflower deleted the dayflower:fix-time-limit branch Apr 16, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment