Don't set blank Cache-Control header in Rack::ETag #410

Merged
merged 1 commit into from Aug 26, 2012

4 participants

@stephencelis

A Cache-Control header with an empty string is meaningless (confusing, even, to those inspecting response headers) and slightly wasteful.

@stephencelis stephencelis Don't set blank Cache-Control header in Rack::ETag
A Cache-Control header with an empty string is meaningless (confusing,
even, to those inspecting response headers) and slightly wasteful.

Signed-off-by: Stephen Celis <stephen@stephencelis.com>
cefc6de
@travisbot

This pull request passes (merged cefc6de into e4172e7).

@lgierth

Mmh, not sure why I changed that from [] to "", but definitely sure that Rack::Lint complained. Note to self: give more context in commit messages.

+1

@raggi raggi merged commit 5a4c691 into rack:master Aug 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment