passing additional options in thin handler #439

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@comboy
Contributor
comboy commented Oct 12, 2012

Rack::Handler::Thin.run takes hash as an argument, but it only makes use of :Host and :Port options. Thin::Server.new however also supports options like :signals and :tag ( https://github.com/macournoyer/thin/blob/master/lib/thin/server.rb#L97 ) So it could be nice if these options also were passed.

First commit takes care of the above, and optional second commit is for unlikely case of people still using thin below version 0.8 (5 years old) that doesn't support passing additional options.

@raggi
Member
raggi commented Nov 2, 2012

I cherry-picked these and then fixed the race conditions introduced in 00f9fc1

Thanks.

@raggi raggi closed this Nov 2, 2012
@comboy
Contributor
comboy commented Nov 2, 2012

Was there any? If yes, I'm sorry, I thought first first thread was always dead when second one is started. And I wasn't sure I can add :tag option to other tests.

Anyway, thanks for merging and fixing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment