Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove warnings: 'not used variable' and 'shadowing outer variable' #487

merged 1 commit into from Jan 7, 2013


None yet
2 participants

carlosantoniodasilva commented Jan 7, 2013

Got the following warning when running Rails tests:

rack-1.4.3/lib/rack/utils.rb:8: warning: assigned but unused variable - ruby_engine

The other warning was found when running rack own tests. I believe this can be safely applied to rack-1.4 branch - let me know if a pull request is necessary.

raggi added a commit that referenced this pull request Jan 7, 2013

Merge pull request #487 from carlosantoniodasilva/remove-warnings
Remove warnings: 'not used variable' and 'shadowing outer variable'

@raggi raggi merged commit 195054c into rack:master Jan 7, 2013

1 check passed

default The Travis build passed

raggi commented Jan 7, 2013


@carlosantoniodasilva carlosantoniodasilva deleted the carlosantoniodasilva:remove-warnings branch Jan 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment