add delegate of to_io method for native function like rb_io_get_io. #594

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@minoritea

When I passed HijackWrapper instances to IO::select, it raises TypeError because this method calls rb_io_get_io, a native function, only accepts IO instances.
Add "to_io" method for converting the wrappers to IO instances automatically.

@raggi

This comment has been minimized.

Show comment
Hide comment
@raggi

raggi Dec 4, 2013

Member

This is a major spec change as it's a required specification, needs to be delayed for a major release, or specified as optional.

Member

raggi commented Dec 4, 2013

This is a major spec change as it's a required specification, needs to be delayed for a major release, or specified as optional.

@raggi

This comment has been minimized.

Show comment
Hide comment
@raggi

raggi Dec 4, 2013

Member

(i do like the idea)

Member

raggi commented Dec 4, 2013

(i do like the idea)

@raggi raggi added this to the Rack 1.6 milestone Jul 12, 2014

@raggi

This comment has been minimized.

Show comment
Hide comment
@raggi

raggi Jul 12, 2014

Member

Happy to add to 1.6 if moved to optional.

Member

raggi commented Jul 12, 2014

Happy to add to 1.6 if moved to optional.

@raggi

This comment has been minimized.

Show comment
Hide comment
@raggi

raggi Aug 3, 2014

Member

Closing waiting for response to review.

Member

raggi commented Aug 3, 2014

Closing waiting for response to review.

@raggi raggi closed this Aug 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment