Add OPTIONS support to File and MockRequest. #614

Merged
merged 2 commits into from Dec 5, 2013

3 participants

@pete

Also update the specs for same.

RFC 2616, section 9.2 specifies OPTIONS requests. Not much effort to
support it for this case; there's already an ALLOWED_VERBS cosntant in
Rack::File, and the spec describes the body of the request as optional.

pete added some commits Oct 21, 2013
@pete pete Add OPTIONS support to File and MockRequest.
Also update the specs for same.

RFC 2616, section 9.2 specifies OPTIONS requests.  Not much effort to
support it for this case; there's already an ALLOWED_VERBS cosntant in
Rack::File, and the spec describes the body of the request as optional.
3ea1174
@pete pete Minor fix to Rack::File OPTIONS for Lint. 4939e5d
@pete

Didn't see any docs specifying how you guys want Pull Requests to work or anything like that; hope the way I did it is appropriate.

@rkh
Official Rack repositories member

PR like this is fine, thanks. :)

I for one am generally +1 on this.

@pete

Thanks! I figure the changes are unobtrusive enough that they won't cause any unforeseen problems, but I can adjust if necessary (e.g., I fixed a string of method definitions that looked like they were supposed to be aligned vertically, which was a bit more speculative).

@tenderlove tenderlove merged commit ee69ce3 into rack:master Dec 5, 2013

1 check passed

Details default The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment