Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Revert-replace characters rather than removing them #626

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

vipulnsward commented Nov 29, 2013

Revert- replace characters rather than removing them

Reason - It breaks with ArgumentError: invalid byte sequence in UTF-8

@tenderlove - this PR is just for reference.

Revert-
replace characters rather than removing them

Reason - It breaks with `ArgumentError: invalid byte sequence in UTF-8`
Member

tenderlove commented Nov 30, 2013

Can you demo the error? I have a green build

Member

tenderlove commented Nov 30, 2013

Nevermind, it fails on Ruby 2.0.0. Removing characters rather than using replacement characters is a pretty bad idea (plus this isn't very performant). Can you figure out why replacement characters aren't working in Ruby 2.0 (but work in 2.1)?

Member

tenderlove commented Nov 30, 2013

Should be fixed in 9fffe5c.

Thanks for reporting this!

@tenderlove tenderlove closed this Nov 30, 2013

Contributor

vipulnsward commented Nov 30, 2013

Thanks @tenderlove !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment