Fix semicolons as separators for GET #781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix to use semicolons as separators for GET not for POST A semicolon ';' should be used as a separator according to a W3.org recommendation http://www.w3.org/TR/1999/REC-html401-19991224/appendix/notes.html#h-B.2.2 The following commit was for only POST not for GET, but the test is written for GET, which is kind of a discrepancy. Do not truncate POST data on `;`, closes rack#543 rack@71c6911
|
👍 |
Contributor
|
👍 /cc @raggi since you committed can you take a look at this one? |
Member
|
@spastorino all yours bro ❤️ |
spastorino
added a commit
that referenced
this pull request
Apr 6, 2015
Fix semicolons as separators for GET
eileencodes
added a commit
to eileencodes/rails
that referenced
this pull request
Apr 6, 2015
Recently rack was changed to have a second argument on the `parse_query` method (in rack/rack#781). Rails relies on this and it's `parse_query` method was missing the second argument. I've bumped rack in the gemspec until it can be released so that tests between Rails master and Rack master pass.
eileencodes
added a commit
to eileencodes/rails
that referenced
this pull request
Apr 6, 2015
Recently rack was changed to have a second argument on the `parse_query` method (in rack/rack#781). Rails relies on this and it's `parse_query` method was complaining aobut missing the second argument. I changed the arguments to `*` so we don't have this issue in the future and I've bumped rack in the gemspec until it can be released so that tests between Rails master and Rack master pass.
Member
|
This caused a bug in Rails if running rails master with rack master because the method signature of Open PR for fix: rails/rails#19665 |
eileencodes
added a commit
to eileencodes/rails
that referenced
this pull request
Apr 6, 2015
Recently rack was changed to have a second argument on the `parse_query` method (in rack/rack#781). Rails relies on this and it's `parse_query` method was complaining about missing the second argument. I changed the arguments to `*` so we don't have this issue in the future.
Contributor
|
👍 |
Contributor
|
@eileencodes just in case did this d68b93a |
Member
|
👍 thanks! |
Contributor
Author
|
Thank you for merging this PR and fixing the bug d68b93a! |
|
Looks like this fix did not make it into 1.6.1? Should it also be fixed in the 1.6 stable branch? |
|
@spastorino Do you think this fix can also make it into the 1.6 branch? I checked but the new 1.6.2 doesn't seem to contain this fix. |
Contributor
|
/cc @tenderlove |
Member
|
Yep, I'll backport this. |
spastorino
added a commit
that referenced
this pull request
Jun 17, 2015
Fix semicolons as separators for GET
|
@tenderlove Thanks! |
ericboehs
referenced
this pull request
Jun 18, 2015
This was referenced Jun 18, 2015
Contributor
|
Backporting this Did Not Go Well. Hopefully #899 will do better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to use semicolons as separators for GET not for POST.
(cf. issue: Truncation of POST data on semicolon during param processing (unencoding?) #543)
A semicolon ';' should be used as a separator according to a W3.org recommendation
http://www.w3.org/TR/1999/REC-html401-19991224/appendix/notes.html#h-B.2.2
The commit 71c6911 was the one for only POST not for GET, but the test was written for GET, which is kind of a discrepancy.