New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for Template::Flute::Iterator::JSON #116

Merged
merged 2 commits into from Aug 6, 2015

Conversation

Projects
None yet
2 participants
@paultcochrane
Contributor

paultcochrane commented Aug 6, 2015

I noticed that the code coverage for Template::Flute::Iterator::JSON was at roughly 33% and thought I'd add some more tests. These tests bring the coverage over 90%. I've got a few questions about the remaining parts of the code, which I'll ask via IRC when I get the time (and you have time, of course!).

Comments or questions about the PR are most certainly welcome!

paultcochrane added some commits Aug 6, 2015

Add tests of reading JSON from file
This exercises more code in Template::Flute::Iterator::JSON and verifies
the documented behaviour.
@racke

This comment has been minimized.

Show comment
Hide comment
@racke

racke Aug 6, 2015

Owner

Excellent, thanks. It might be also interesting to test whether it handles files with UTF-8 content correctly.
Please continue with adding test coverage, that is really useful. Especially as I plan to migrate Template::Flute to using Moo.

Owner

racke commented Aug 6, 2015

Excellent, thanks. It might be also interesting to test whether it handles files with UTF-8 content correctly.
Please continue with adding test coverage, that is really useful. Especially as I plan to migrate Template::Flute to using Moo.

racke added a commit that referenced this pull request Aug 6, 2015

Merge pull request #116 from paultcochrane/pr/test-flute-iterator-json
Add more tests for Template::Flute::Iterator::JSON

@racke racke merged commit 40886e1 into racke:master Aug 6, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment