New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check utf8 JSON input in Iterator::JSON #118

Merged
merged 3 commits into from Aug 8, 2015

Conversation

Projects
None yet
2 participants
@paultcochrane
Contributor

paultcochrane commented Aug 7, 2015

These commits fix a bug in PR #116, localise the variables in the Iterator::JSON tests, and add tests for utf8 input as mentioned in the closing comments of PR #116.

paultcochrane added some commits Aug 7, 2015

Fix file iterator to check
The iterator being checked was actually that from the global scope and not
the file iterator which supposed to be checked.  This issue has now been
corrected.
Wrap JSON iterator test blocks in subtests
This localises more variables and highlighted the bug fixed in the previous
commit.
@racke

This comment has been minimized.

Show comment
Hide comment
@racke

racke Aug 8, 2015

Owner

Thanks a lot!!

Owner

racke commented Aug 8, 2015

Thanks a lot!!

racke added a commit that referenced this pull request Aug 8, 2015

@racke racke merged commit 978a4e6 into racke:master Aug 8, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment