New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve kwalitee #121

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@paultcochrane
Contributor

paultcochrane commented Aug 8, 2015

A set of changes to improve the distribution's kwalitee (http://cpants.cpanauthors.org/dist/Template-Flute).

@racke

This comment has been minimized.

Show comment
Hide comment
@racke

racke Aug 10, 2015

Owner

Actually I don't want to add dependencies for the filters added to Template::Flute. The prerequisites for the filters are in the documentation.

Owner

racke commented Aug 10, 2015

Actually I don't want to add dependencies for the filters added to Template::Flute. The prerequisites for the filters are in the documentation.

@paultcochrane

This comment has been minimized.

Show comment
Hide comment
@paultcochrane

paultcochrane Aug 10, 2015

Contributor

So, should I simply remove those dependencies, update the branch, and git push --force ?

Contributor

paultcochrane commented Aug 10, 2015

So, should I simply remove those dependencies, update the branch, and git push --force ?

@racke

This comment has been minimized.

Show comment
Hide comment
@racke

racke Aug 10, 2015

Owner

Yes, please.

Owner

racke commented Aug 10, 2015

Yes, please.

paultcochrane added some commits Aug 8, 2015

Add missing modules to PREREQ_PM
Even though the distribution installs and builds correctly, mentioning all
required modules helps things like metacpan find and display the correct
dependencies.  This helps the dist's kwalitee and aids in determining the
"river of CPAN" (see http://neilb.org/2015/04/20/river-of-cpan.html), which
is good for the entire Perl module ecosystem.
Add missing test modules to Makefile.PL
The list of modules used to test `Template::Flute` is now complete.  This
helps improve distribution kwalitee and helps out services such as metacpan
get the dependency list correct.
Specify an explicit minimum Perl version
I know we already discussed this on IRC, but I happened to find that the
minimum version was actually higher than 5.6.  It turns out that certain
minimum syntax features used in Template::Flute require at least 5.8, thus
it would help anyone installing the module on an old system (and anyone
testing on old systems) if they knew early on that the module won't work
without at least this minimum version.  Hence, I've added this commit here.
It's also not a large change, so I hope you can accept it.
@paultcochrane

This comment has been minimized.

Show comment
Hide comment
@paultcochrane

paultcochrane Aug 11, 2015

Contributor

Have updated the commits and git push --force updated the branch. The filter-related dependencies have been removed. I've left JSON in though, since it is also used in Template::Flute::Iterator::JSON. Hope that is the right thing to do.

Contributor

paultcochrane commented Aug 11, 2015

Have updated the commits and git push --force updated the branch. The filter-related dependencies have been removed. I've left JSON in though, since it is also used in Template::Flute::Iterator::JSON. Hope that is the right thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment