fix(api): 405 Method Not Allowed - False positive #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,14 +12,14 @@ This requires some discipline on the part of the developer. | |||
|
|
|||
| ### Misc. ### | |||
|
|
|||
| * Falcon probably isn't thread-safe, so don't try it. Run multiple worker processes, each with a non-blocking I/O loop instead. | |||
| * Falcon has not been designed particularly to be thread-safe, so don't try it. Run multiple worker processes, each with a non-blocking I/O loop instead. | |||
There was a problem hiding this comment.
Falcon is not thread-safe. I suggest replacing the first sentence with this, while continuing to offer the advice in the second sentence.
Express more with less. :)
There was a problem hiding this comment.
Let me do that. I noticed after the fact my mistake, but was being lazy. Thanks for the nudge. 👍
|
Just one documentation nit. Everything else LGTM. |
This patch removes the TypeError heuristic code altogether, since it
has been problematic in the past (and often masks app bugs).
BREAKING CHANGE: You can no longer overload a single resource class to
respond to multiple routes that differ by URI template params. This
has come to be viewed as an anti-pattern, and so it will no longer
be supported.
If you attempt to have a single OxResource that you try to overload to
respond to both, e.g., "PUT /oxen/old-ben" and "GET /oxen", it will
no longer work after this commit.
Developers should be advised to resist the temptation to overload their
resources; instead, create OxResource and OxenResource. It is common to
put these two classes in the same module.
Fixes Issue falconry#205
kgriffs
pushed a commit
that referenced
this pull request
Dec 16, 2013
fix(api): 405 Method Not Allowed - False positive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the TypeError heuristic code altogether, since it
has been problematic in the past (and often masks app bugs).
BREAKING CHANGE: You can no longer overload a single resource class to
respond to multiple routes that differ by URI template params. This
has come to be viewed as an anti-pattern, and so it will no longer
be supported.