Refactor timeline to look nice, be awesome #80

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
@fsargent
Contributor

fsargent commented Apr 16, 2012

Refactor timeline to look like a london underground tube map, possibly datavis using D3.

fsargent added some commits Apr 16, 2012

Refactored how we deal with middleware which doesnt have data in devo…
…ps.json. see readme.md in middleware folder. Timeline will use any date format that javascripts Date() function accepts.
@fsargent

This comment has been minimized.

Show comment
Hide comment
@fsargent

fsargent Apr 19, 2012

Contributor

This can be reviewed now. Lots of little fixes for other things, not specifically the timeline.

Contributor

fsargent commented Apr 19, 2012

This can be reviewed now. Lots of little fixes for other things, not specifically the timeline.

@kans

This comment has been minimized.

Show comment
Hide comment
@kans

kans Apr 19, 2012

Contributor

Why did this line get moved from create_middleware into all the middlewares?

  • if (api_config === undefined ) {
  •  payload = null ;
    
  •  next();
    
  •  return;
    
  • }
Contributor

kans commented Apr 19, 2012

Why did this line get moved from create_middleware into all the middlewares?

  • if (api_config === undefined ) {
  •  payload = null ;
    
  •  next();
    
  •  return;
    
  • }
@fsargent

This comment has been minimized.

Show comment
Hide comment
@fsargent

fsargent Apr 19, 2012

Contributor

The previous version looks like this:

return function(req, res, next){
    if (!req.devops.related_apis || !req.devops.related_apis[name]) {
      req.devops[name] = null;

Now all the middlewares check themselves to see if they have credentials, rather than it being built into the create_middleware.
I believe this is better because now we're not tieing middlewares directly to related_api credentials. We use middlewares for much more than that now.

Contributor

fsargent commented Apr 19, 2012

The previous version looks like this:

return function(req, res, next){
    if (!req.devops.related_apis || !req.devops.related_apis[name]) {
      req.devops[name] = null;

Now all the middlewares check themselves to see if they have credentials, rather than it being built into the create_middleware.
I believe this is better because now we're not tieing middlewares directly to related_api credentials. We use middlewares for much more than that now.

@ggreer

This comment has been minimized.

Show comment
Hide comment
@ggreer

ggreer Apr 19, 2012

Contributor

Looks like a lot of tests are broken on this branch.

Contributor

ggreer commented Apr 19, 2012

Looks like a lot of tests are broken on this branch.

@ggreer

This comment has been minimized.

Show comment
Hide comment
@ggreer

ggreer Apr 30, 2012

Contributor

I cherry-picked the styling changes. The middlewares have been refactored quite a bit, so the rest of this can't be merged.

Contributor

ggreer commented Apr 30, 2012

I cherry-picked the styling changes. The middlewares have been refactored quite a bit, so the rest of this can't be merged.

@ggreer ggreer closed this Apr 30, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment