Skip to content

D-16638: Min required lenght validator (Not Ready) #31

Merged
merged 3 commits into from Dec 30, 2013

4 participants

@Jigarsolanki

No description provided.

@jpbochi
jpbochi commented Dec 30, 2013

if @laurendowdy approved, it LGTM

@Jigarsolanki Jigarsolanki merged commit 5a41377 into master Dec 30, 2013

1 check passed

Details default The Travis CI build passed
@luizfar luizfar commented on the diff Dec 30, 2013
spec/validators/min-length-validaor-spec.js
@@ -0,0 +1,28 @@
+describe('ko.validators.minLengthValidator', function() {
@luizfar
luizfar added a note Dec 30, 2013

There's a typo in the filename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@laurenpuckett

Will this grab the label from the field? If not, we may need to say "[Field] must contain at least 3 characters", to cover a bigger variety of labels.

Okay I will change that in next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.