New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds protocol class option to act as a full graphite replacement. #19

Merged
merged 1 commit into from Jun 28, 2016

Conversation

Projects
None yet
3 participants
@nicholaskuechler
Copy link
Contributor

nicholaskuechler commented Jun 28, 2016

Currently, blueflood-carbon-forwarder can only receive pickle metrics, which means you have to have carbon-relay (or something similar) relaying metrics to blueflood-carbon-forwarder via pickled data.

With this PR, we will have the option to choose between received pickled metrics and receiving raw text metrics. The raw text metrics are what graphite itself is receiving.

This means I won't need to run the intermediate graphite node in order to get metrics from hosts via diamond, scripts, etc. -- I can now send directly from diamond to blueflood via blueflood-carbon-forwarder when running with the MetricLineReceiver protocol (rather than pickled protocol).

if options['protocol'] == "MetricPickleReceiver":
protocol_cls = MetricPickleReceiver
elif options['protocol'] == "MetricLineReceiver":
protocol_cls = MetricLineReceiver

This comment has been minimized.

@VinnyQ

VinnyQ Jun 28, 2016

Contributor

where's MetricLineReceiver defined? Is it part of some library?

This comment has been minimized.

@VinnyQ

VinnyQ Jun 28, 2016

Contributor

Oh nevermind, it's part of protocol.py where MetricPickleReceiver is also defined.

@shintasmith

This comment has been minimized.

Copy link
Contributor

shintasmith commented Jun 28, 2016

looks good to me

@VinnyQ

This comment has been minimized.

Copy link
Contributor

VinnyQ commented Jun 28, 2016

👍 lgtm.

@VinnyQ VinnyQ merged commit 81de0e0 into rackerlabs:master Jun 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment