New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial clean up of Astyanax ColumnFamily #646

Merged
merged 4 commits into from Mar 8, 2016

Conversation

Projects
None yet
5 participants
@shintasmith
Contributor

shintasmith commented Mar 7, 2016

Why
Eventually, we will be moving to using Datastax driver and removing Astyanax, in preparation to upgrading to Cassandra 2.1.13.

This PR removes some unnecessary use of Astyanax's ColumnFamily model class. Blueflood already provides a wrapper class called MetricColumnFamily, which extends the Astyanax ColumnFamily class. But for some reasons some code are written to return Astyanax ColumnFamily directly, propagating the use of this class in more places than necessary.

How

  • Change the CassandraModel.getColumnFamily() method to return MetricColumnFamily.
  • Change all consumer of this method accordingly.

A small other clean up I did was to move the class IntegrationBaseTest.java from src/main to src/integration-test. To make this move successful, I have to also change .travis.yml. Before the PR, we were calling mvn package before running the tests. I think that is incorrect. We should package after tests are running successfully.

I have run the unit & integration tests and they all have passed.

@ChandraAddala

This comment has been minimized.

Contributor

ChandraAddala commented Mar 7, 2016

Tests seem to be failing. Other than that everything looks good.

@shintasmith

This comment has been minimized.

Contributor

shintasmith commented Mar 7, 2016

Yeah... I'm working on it. One of the base class IntegrationBaseTest.java was placed in src/main. I thought I would move it to the right place, which is src/integration-test. But Travis is not happy yet..

@shintasmith

This comment has been minimized.

Contributor

shintasmith commented Mar 8, 2016

@usnavi

This comment has been minimized.

Contributor

usnavi commented Mar 8, 2016

lgtm

@ChandraAddala

This comment has been minimized.

Contributor

ChandraAddala commented Mar 8, 2016

Looks good.

@shintasmith

This comment has been minimized.

Contributor

shintasmith commented Mar 8, 2016

thanks all

shintasmith added a commit that referenced this pull request Mar 8, 2016

Merge pull request #646 from shintasmith/driver_premigration
initial clean up of Astyanax ColumnFamily

@shintasmith shintasmith merged commit 2d4972e into rackerlabs:master Mar 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@izrik

This comment has been minimized.

Member

izrik commented Mar 10, 2016

@shintasmith I've run into this problem before. I found that the integration-test phase comes after the package phase. Integration tests can't be run before then. More info here: https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#Lifecycle_Reference

@shintasmith

This comment has been minimized.

Contributor

shintasmith commented Mar 10, 2016

@izrik, I have fixed this

@coveralls

This comment has been minimized.

coveralls commented Mar 12, 2018

Coverage Status

Coverage decreased (-30.4%) to 42.727% when pulling 34f7547 on shintasmith:driver_premigration into 9795c45 on rackerlabs:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment