New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end-to-end BF + Grafana docker compose example #819

Merged
merged 2 commits into from Jan 11, 2018

Conversation

Projects
None yet
4 participants
@itzg
Collaborator

itzg commented Jan 11, 2018

No description provided.

@itzg itzg requested review from GeorgeJahad and mritunjaykumar Jan 11, 2018

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 11, 2018

Coverage Status

Changes Unknown when pulling 91dfb2a on itzg/bf_plus_grafana_docker_compose into ** on master**.

coveralls commented Jan 11, 2018

Coverage Status

Changes Unknown when pulling 91dfb2a on itzg/bf_plus_grafana_docker_compose into ** on master**.

@itzg

This comment has been minimized.

Show comment
Hide comment
@itzg

itzg Jan 11, 2018

Collaborator

I situated this new compose file in a new directory because compose derives the project name from the current directory name and in turn the container names from the project name. The other directory resulted in container names like "blueflooddockercompose_blueflood_1" and felt too long to me :)

In the directory I created the prefix becomes "bfgrana_".

Collaborator

itzg commented Jan 11, 2018

I situated this new compose file in a new directory because compose derives the project name from the current directory name and in turn the container names from the project name. The other directory resulted in container names like "blueflooddockercompose_blueflood_1" and felt too long to me :)

In the directory I created the prefix becomes "bfgrana_".

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 11, 2018

Coverage Status

Changes Unknown when pulling 8cdcf34 on itzg/bf_plus_grafana_docker_compose into ** on master**.

coveralls commented Jan 11, 2018

Coverage Status

Changes Unknown when pulling 8cdcf34 on itzg/bf_plus_grafana_docker_compose into ** on master**.

@mritunjaykumar

Looks good to me. :-)

@itzg itzg merged commit a03279e into master Jan 11, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@itzg itzg deleted the itzg/bf_plus_grafana_docker_compose branch Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment